From: Gary V. Vaughan <git@mlists.thewrittenword.com>
Date: Tue, 27 Apr 2010 14:32:04 GMT
Subject: Re: [patch 02/16] const-expr.patch
Message-ID: <20100427143204.GA36271@thor.il.thewrittenword.com>
In-Reply-To: <l2t40aa078e1004270708w905ae1e1lbead0f21acc70dee@mail.gmail.com>

On Tue, Apr 27, 2010 at 04:08:24PM +0200, Erik Faye-Lund wrote:
> On Tue, Apr 27, 2010 at 3:57 PM, Gary V. Vaughan
> <git@mlists.thewrittenword.com> wrote:
> > Index: b/unpack-trees.c
> > ===================================================================
> > --- a/unpack-trees.c
> > +++ b/unpack-trees.c
> > @@ -287,9 +287,11 @@ static void add_same_unmerged(struct cac
> > ?static int unpack_index_entry(struct cache_entry *ce,
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct unpack_trees_options *o)
> > ?{
> > - ? ? ? struct cache_entry *src[5] = { ce, NULL, };
> > + ? ? ? struct cache_entry *src[5] = { NULL, NULL };
> 
> You don't need NULL twice when the array-size is specified, it's just
> confusing as the array has 5 elements. [[..and 2 other similar
> instances...]]

Thanks, agreed.  I won't spam the list with another copy of the patch
with such straight forward changes though.

Cheers,
-- 
Gary V. Vaughan (gary@thewrittenword.com)