From: Jeff King <peff@peff.net>
Date: Mon, 26 Apr 2010 19:10:56 GMT
Subject: Re: [PATCH 2/2] wt-status: take advice.statusHints seriously
Message-ID: <20100426191056.GB10772@coredump.intra.peff.net>
In-Reply-To: <4BD155D0.5080402@drmicha.warpmail.net>

On Fri, Apr 23, 2010 at 10:09:52AM +0200, Michael J Gruber wrote:

> Tay Ray Chuan venit, vidit, dixit 23.04.2010 06:15:
> > Hi,
> > 
> > On Fri, Apr 23, 2010 at 4:30 AM, Michael J Gruber
> > <git@drmicha.warpmail.net> wrote:
> >>                else if (s->untracked.nr)
> >> -                       printf("nothing added to commit but untracked files present (use \"git add\" to track)\n");
> >> +                       printf("nothing added to commit but untracked files present%s\n",
> >> +                               advice_status_hints
> >> +                               ? " (use \"git add\" to track)" : "");
> > 
> > while we're at it, perhaps we could put the hints on its own line,
> 
> I don't think I'm the only one to turn sour at every encounter with the
> phrase "while we're at it". I did fix one extraneous space in code
> "while I was at it", yes, but:

Just my 2 cents, but I find "while we're at it" comments are taken much
better when accompanied by a patch (either squashable or to be applied
on top). :)

-Peff