From: Björn Steinbrink <b.steinbrink@gmx.de>
Date: Fri, 23 Apr 2010 09:39:43 GMT
Subject: Re: Please default to 'commit -a' when no changes were added
Message-ID: <20100423093943.GB30346@atjola.homenet>
In-Reply-To: <87sk6n4426.fsf@frosties.localdomain>

On 2010.04.22 22:37:05 +0200, Goswin von Brederlow wrote:
> Is there a risk? You do get an editor with all the files affected listed
> giving you a big fat warning what you are about to commit.

And if I happen to have two unrelated changes in a single file that's
worth nothing at all. For example, I might have changed the condition
that causes some message to be shown, and discovered a typo in the
message itself and fixed it along the way. That needs two commits, but
the list of modified files doesn't tell that.

Only "commit -v" would help there, showing the diff in the editor. But
reviewing the diff in the editor is a PITA and I lose the whole review
progress if I find something I don't want to commit and have to abort.
Using "git add [-i|-p|-e]", git helps me to keep track of the changes I
already reviewed and decided to commit.

Björn