From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 15 Apr 2010 19:34:09 GMT
Subject: Re: [PATCH 5/6] http-fetch: Use index-pack rather than verify-pack to check packs
Message-ID: <201004152134.10555.j6t@kdbg.org>
In-Reply-To: <1271358560-8946-6-git-send-email-spearce@spearce.org>

On Donnerstag, 15. April 2010, Shawn O. Pearce wrote:
> +test_expect_success 'fetch notices corrupt pack' '
> +	cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/repo_pack.git
> "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad1.git && +	(cd
> "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad1.git &&
> +	 p=`ls objects/pack/pack-*.pack` &&
> +	 chmod u+w $p &&
> +	 dd if=/dev/zero of=$p bs=256 count=1 seek=1

Since the particular byte that overwrites the pack is irrelevant, please make 
this:

	printf %0256d 0 | dd of=$p bs=256 count=1 seek=1

for the benefit of us poor Windowsers who do not have /dev/zero.

Perhaps you want to add conv=notrunc.

Ditto in patch 6/6.

Thanks,
-- Hannes