From: Jeff King <peff@peff.net>
Date: Tue, 13 Apr 2010 10:03:04 GMT
Subject: Re: [PATCHv2] pretty: Initialize notes if %N is used
Message-ID: <20100413100304.GA29101@coredump.intra.peff.net>
In-Reply-To: <1271149186-30156-1-git-send-email-heipei@hackvalue.de>

On Tue, Apr 13, 2010 at 10:59:46AM +0200, Johannes Gilger wrote:

> Thanks for the feedback Jeff. I've put your suggestions into my patch
> and tried to come up with a sensible name for 'userformat_fill_want'.
> As you can see I called it 'userformat_find_requirements', but am not
> really satisfied with it since it's too long and not quite to the
> point.
> 
> Anything else missing?

This version looks good to me.

Two minor comments:

> -	if (!rev->show_notes_given && !rev->pretty_given)
> +	userformat_find_requirements(NULL,&w);

 1. Style, no whitespace between arguments.

 2. That function name also sucks. I doubt it is worth spending more
    time on, though.

-Peff