From: Jeff King <peff@peff.net>
Date: Fri, 02 Apr 2010 16:57:59 GMT
Subject: Re: [PATCH 4/4] git status: refresh the index
Message-ID: <20100402165759.GB18576@coredump.intra.peff.net>
In-Reply-To: <1270211241-10795-5-git-send-email-markus.heidelberg@web.de>

On Fri, Apr 02, 2010 at 02:27:21PM +0200, Markus Heidelberg wrote:

> +	fd = hold_locked_index(&index_lock, 1);
> +	if (write_cache(fd, active_cache, active_nr) ||
> +	    commit_locked_index(&index_lock))
> +		die("unable to write new_index file");

Does this mean we will fail to run in a read-only repository? I think
that status, like diff, should refresh the index on disk if it _can_,
but as that refresh is a side effect of the main purpose (which is to
output information), it should not be fatal if it cannot do so.

-Peff