From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 28 Mar 2010 18:23:00 GMT
Subject: Re: [PATCH 3/3] diff: add "fasttextconv" config option
Message-ID: <201003282023.00913.j6t@kdbg.org>
In-Reply-To: <20100328145421.GC27970@coredump.intra.peff.net>

On Sonntag, 28. März 2010, Jeff King wrote:
> +	if (start_command(&child) != 0 ||
> +	    strbuf_read(&buf, child.out, 0) < 0 ||
> +	    finish_command(&child) != 0) {

This conditional is somewhat dubious. If strbuf_read fails, you do not wait 
for the child, and a zombie remains.

The have this sequence already in run_textconv().

-- Hannes