From: Jonathan Nieder Date: Sat, 20 Mar 2010 05:14:14 GMT Subject: [PATCH 4/5] tag -v: Do not spawn a separate process for verify-tag Message-ID: <20100320051414.GD24791@progeny.tock> In-Reply-To: <20100320050953.GA24746@progeny.tock> Aside from handling of SIGPIPE, there was no reason for verify-tag to run in a separate process. Not much advantage to this I can see. It just simplifies things a little. Signed-off-by: Jonathan Nieder --- builtin/tag.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/builtin/tag.c b/builtin/tag.c index d56c882..d138e0c 100644 --- a/builtin/tag.c +++ b/builtin/tag.c @@ -147,11 +147,7 @@ static int delete_tag(const char *name, const char *ref, static int verify_tag(const char *name, const char *ref, const unsigned char *sha1) { - const char *argv_verify_tag[] = {"git", "verify-tag", - "-v", "SHA1_HEX", NULL}; - argv_verify_tag[3] = sha1_to_hex(sha1); - - if (run_command_v_opt(argv_verify_tag, 0)) + if (verify_tag_signature(sha1_to_hex(sha1), 1)) return error("could not verify the tag '%s'", name); return 0; } -- 1.7.0.2