From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Sat, 27 Feb 2010 20:41:11 GMT
Subject: Re: Re: Re: git gui create desktop icon currently does not work
Message-ID: <20100227204108.GA33000@book.hvoigt.net>
In-Reply-To: <cb7bb73a1002242353h739786bdlb2c57df3438f5b7f@mail.gmail.com>

On Thu, Feb 25, 2010 at 08:53:57AM +0100, Giuseppe Bilotta wrote:
> On Wed, Feb 24, 2010 at 12:02 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > On Tue, Feb 23, 2010 at 11:54:40PM +0100, Giuseppe Bilotta wrote:
> >> On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
[...]
> >> > -                                       [file normalize [$_gitworktree]]
> >> > +                                       [file normalize $_gitworktree]
> >> >                        } err]} {
> >> >                        error_popup [strcat [mc "Cannot write shortcut:"] "\n\n$err"]
> >> >                }
> >>
> >> Ouch. Yes, I think your patch is obviously correct.
> >>
> >> (I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...)
> >
> > No problem obviously nobody else saw this, but please test your patches
> > in the future. That could have avoided this one.
> 
> You're right, although finding a Windows installation on which to test
> git is nontrivial for me. (I did mention this particular part was
> untested when I submitted it.)

Ok then we can not blame you. Maybe send such a patch to the msysgit
mailinglist and me CC then we can test early.

> > One thing which is missing from my patch is the cygwin part which, as I
> > saw from your original patch, has the same problem.
> 
> Also, I'm wondering: does the Windows part actually need a  [file
> nativename $_gitworktree], or is this automatically handled by the
> shortcut creation code?

I investigated further and it seems that the cygwin part needs it. I
prepared a patchseries about this and some more issues I will send out
shortly.

cheers Heiko