From: Teemu Matilainen <teemu.matilainen@iki.fi>
Date: Tue, 23 Feb 2010 16:02:30 GMT
Subject: Re: [PATCH 1/2] bash: Enable completion for external subcommands
Message-ID: <20100223160230.GB837@reaktor.fi>
In-Reply-To: <20100223155007.GB10772@neumann>

On Tue, 23 Feb 2010, SZEDER Gábor wrote:

> On Tue, Feb 23, 2010 at 04:43:12PM +0200, Teemu Matilainen wrote:
> > This makes it possible to have completion also for external git
> > subcommands.
> 
> this issue was raised a few weeks ago, and the discussion led to a
> similar patch back then.  However, Junio mentioned a few concerns
> regarding this approach, and, since it was v1.7.0-rc time and this was
> clearly a post v1.7.0 change, I didn't pursue the discussion and
> didn't send updated patches, and then forgot it completely.  I will
> try to find some time in the evening to get the commit messages in
> shape send out the updates.  In the meantime please have a look at
> Junio's concerns about this approach:
> http://thread.gmane.org/gmane.comp.version-control.git/138316/focus=138348

Ugh.  I *tried* to search the mailing list, but apparently failed...
Funny that anyway we got almost identical solution.

Thanks for the pointer.  I'll be waiting for the new patch.

-- 
	- Teemu