From: Jeff King <peff@peff.net>
Date: Mon, 22 Feb 2010 11:23:26 GMT
Subject: Re: [PATCH] Disable OpenSSL SHA1 implementation by default
Message-ID: <20100222112326.GA21929@coredump.intra.peff.net>
In-Reply-To: <20100222110814.GA3247@progeny.tock>

On Mon, Feb 22, 2010 at 05:08:14AM -0600, Jonathan Nieder wrote:

> The OpenSSL SHA-1 routine is about as fast as block-sha1, but linking
> to libcrypto slows down the startup of git commands by an appreciable
> amount.  Use the BLK_SHA1 implementation by default instead.

What is your definition of "about as fast"? I benchmarked up to a 20%
slow-down a while back:

  http://article.gmane.org/gmane.comp.version-control.git/126995

Now my complaint then was specifically about removing openssl sha1
support entirely, and I have no problem with setting OPENSSL_SHA1 in my
build options, but it does make sense to me that the default should
be whatever is fastest for most people. And that means benchmarking
blk_sha1 versus the libcrypto linking slow-down on several machines to
get actual numbers.

Unfortunately, I think we may end up with an apples-to-oranges
comparison, as sha1-heavy tasks are affected one way, and scripted
many-git-invocation tasks the other way.

> Typed “make NO_OPENSSL=1” for the umpteenth time today, but this time
> I thought I should something about it.

echo 'NO_OPENSSL=1' >config.mak ?

> -ifndef NO_OPENSSL
> +ifdef OPENSSL_TLS
> +	BASIC_CFLAGS += -DOPENSSL_TLS
> +	USE_OPENSSL = Yes
> +endif

Doesn't this flip the default for using TLS on imap-send?

-Peff