From: Jeff King <peff@peff.net>
Date: Thu, 18 Feb 2010 01:38:22 GMT
Subject: Re: [PATCH] Teach "git add" and friends to be paranoid
Message-ID: <20100218013822.GB15870@coredump.intra.peff.net>
In-Reply-To: <7vljer1gyg.fsf_-_@alter.siamese.dyndns.org>

On Wed, Feb 17, 2010 at 05:16:23PM -0800, Junio C Hamano wrote:

> +	if (paranoid) {
> +		unsigned char stablebuf[262144];

Is 256K a bit big for allocating on the stack? Modern OS's seem to give
us at least a couple of megabytes (my Linux boxen all have 8M, and
even Solaris 8 seems to have that much). But PTHREAD_STACK_MIN is only
16K (I don't think it is possible to hit this code path in a thread
right now, but I'm not sure). And I have no idea what the situation is
on Windows.

I dunno if it is worth worrying about, but maybe somebody more clueful
than me can comment.

-Peff