From: Jakub Narebski <jnareb@gmail.com>
Date: Wed, 17 Feb 2010 16:26:53 GMT
Subject: Re: [PATCH 2/2] gitweb: Protect escaping functions against calling on undef
Message-ID: <201002171726.53418.jnareb@gmail.com>
In-Reply-To: <20100207205130.11146.30664.stgit@localhost.localdomain>

On Sun, 7 Feb 2010, Jakub Narebski wrote:

> This is a bit of future-proofing esc_html and friends: when called
> with undefined value they would now would return undef... which would
> probably mean that error would still occur, but closer to the source
> of problem.
> 
> This means that we can safely use
>   esc_html(shift) || "Internal Server Error"
> in die_error() instead of
>   esc_html(shift || "Internal Server Error")
> 
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Without the second part (i.e. the change in die_error) those two
> patches would be totally independent.

Ping!

All but last chunk (last chunk depends on PATCH 1/2) are a bit of
hardening / defensive programming... although currently not necessary
(gitweb doesn't pass undef to its escaping subroutines... I think).

-- 
Jakub Narebski
Poland