From: Jeff King <peff@peff.net>
Date: Mon, 15 Feb 2010 07:57:52 GMT
Subject: Re: [PATCH 2/6] Make 'git var GIT_PAGER' always print the configured pager
Message-ID: <20100215075752.GC5347@coredump.intra.peff.net>
In-Reply-To: <20100215054447.GB22121@progeny.tock>

On Sun, Feb 14, 2010 at 11:44:47PM -0600, Jonathan Nieder wrote:

> > I think this is the right thing to do. But isn't "git am" broken in the
> > meantime, as it now always paginates (whereas before, it would never
> > paginate)? You fix it later in the series, but is there any test
> > breakage in the meantime (not rhetorical, I didn't actually check) that
> > would hurt bisectability?
> 
> The behavior before dec543 (am -i, git-svn: use "git var GIT_PAGER",
> 2009-10-30) was to always paginate.  This made some sense, since this
> is the (v)iew command in git am --interactive; whether we check or
> not, presumably stdout is a terminal.  So for git am, this restores
> the older behavior.
> 
> There are unfortunately no tests for am --interactive in the test
> suite, so test suite runs would detect none of this.
> 
> Thank you for your attention to detail.

Makes sense. Thank _you_ for patches and for checking on my concerns.

-Peff