From: Jeff King <peff@peff.net>
Date: Mon, 15 Feb 2010 07:49:22 GMT
Subject: Re: [PATCH] require_work_tree broken with NONGIT_OK
Message-ID: <20100215074922.GA5549@coredump.intra.peff.net>
In-Reply-To: <7vzl3bj95l.fsf@alter.siamese.dyndns.org>

On Sun, Feb 14, 2010 at 10:38:30PM -0800, Junio C Hamano wrote:

> > +	test git rev-parse --is-inside-work-tree >/dev/null 2>&1 ||
> 
> I don't think this would ever work with "test" at the beginning.

Oops. I totally missed that when reviewing the patch. :-/

Thinking on this a bit more, I think Gabriel's script is a little
broken. It sets NONGIT_OK to not have a git repository, but then it
requires a working tree, which doesn't make any sense.

That being said, I think it is still a good change, as the correct error
message is better than the shell barfing.

-Peff