From: Jeff King Date: Thu, 11 Feb 2010 21:06:43 GMT Subject: [PATCH 2/4] cherry-pick: refactor commit parsing code Message-ID: <20100211210642.GB9066@coredump.intra.peff.net> In-Reply-To: <20100211210445.GA8819@coredump.intra.peff.net> These lines are really just lookup_commit_reference re-implemented. Signed-off-by: Jeff King --- Obviously this changes the exact text of the error messages, but I doubt anybody cares too much. builtin-revert.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/builtin-revert.c b/builtin-revert.c index 83e5c0a..012c646 100644 --- a/builtin-revert.c +++ b/builtin-revert.c @@ -68,15 +68,9 @@ static void parse_args(int argc, const char **argv) if (get_sha1(arg, sha1)) die ("Cannot find '%s'", arg); - commit = (struct commit *)parse_object(sha1); + commit = lookup_commit_reference(sha1); if (!commit) - die ("Could not find %s", sha1_to_hex(sha1)); - if (commit->object.type == OBJ_TAG) { - commit = (struct commit *) - deref_tag((struct object *)commit, arg, strlen(arg)); - } - if (commit->object.type != OBJ_COMMIT) - die ("'%s' does not point to a commit", arg); + exit(1); } static char *get_oneline(const char *message) -- 1.7.0.rc2.40.g33ed2.dirty