From: Larry D'Anna Date: Tue, 09 Feb 2010 17:33:07 GMT Subject: Re: [PATCH v2 6/6] receive-pack: Send hook output over side band #2 Message-ID: <20100209173307.GA1115@cthulhu> In-Reply-To: <20100209172027.GC26964@spearce.org> * Shawn O. Pearce (spearce@spearce.org) [100209 12:20]: > Larry D'Anna wrote: > > > > This breaks t5401. See <7v4olqlva7.fsf@alter.siamese.dyndns.org> in another thread. > > No. Your patch causes t5401 to break. If you apply this series on > top of maint, its fine. If you merge this series into master, and > correctly fix the Win32 merge conflict in run-command.c, its fine. Well, the version of this commit that's in pu is defiantly failing t5401 on my machine. Just tested it again with a clean build. My series isn't an ancestor of it either. Did you notice the failure is intermittent? You have to run it a few times before it fails. --larry