From: Larry D'Anna <larry@elder-gods.org>
Date: Mon, 08 Feb 2010 22:15:58 GMT
Subject: Re: [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain
Message-ID: <20100208221558.GA21718@cthulhu>
In-Reply-To: <20100208213256.GA470@coredump.intra.peff.net>

* Jeff King (peff@peff.net) [100208 16:32]:
> > @@ -1071,7 +1071,8 @@ int transport_push(struct transport *transport,
> >  		}
> >  
> >  		if (!quiet && !ret && !refs_pushed(remote_refs))
> > -			fprintf(stderr, "Everything up-to-date\n");
> > +			fprintf(porcelain ? stdout : stderr,
> > +				"Everything up-to-date\n");
> >  		return ret;
> >  	}
> 
> This one, on the other hand, seems to me to be just noise. What does a
> --porcelain caller learn by seeing "Everything up-to-date" that it did
> not already know from seeing the list of refs?

I agree.  I don't see how sending this message to stdout could possibly help the
--porcelain caller.


            --larry