From: Jakub Narebski <jnareb@gmail.com>
Date: Mon, 08 Feb 2010 08:48:26 GMT
Subject: Re: [PATCH] gitweb: Die if there are parsing errors in config file
Message-ID: <201002080948.27094.jnareb@gmail.com>
In-Reply-To: <4B6E9BBB.4000904@eaglescrag.net>

On Sun, 7 Feb 2010, J.H. wrote:

> I'd sign-off that, I've probably run into it a couple of times myself.
> 
> - John 'Warthog9' Hawley

I think you meant ACK, not sign-off...
 
> On 02/07/2010 01:40 AM, Jakub Narebski wrote:
> > Otherwise the errors can propagate, and show in damnest places, and
> > you would spend your time chasing ghosts instead of debugging real
> > problem (yes, it is from personal experience).
> > 
> > This follows (parts of) advice in `perldoc -f do` documentation.
> > 
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> > ---
> > This is fallout from my work on [split] "Gitweb output caching" series.
> > Before I used `die $@ if $@;' in t/t9503/test_cache_interface.pl, tests
> > failed for no discernable reason...
> > 
> > So I think the same should be done for the gitweb config file.
[...]

-- 
Jakub Narebski
Poland