From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 06 Feb 2010 14:34:02 GMT
Subject: Re: [PATCH 4/4] gitweb: show notes in commit(diff) view
Message-ID: <201002061534.02972.jnareb@gmail.com>
In-Reply-To: <cb7bb73a1002060615o261d974cnf347ba5af5ae324b@mail.gmail.com>

Giuseppe Bilotta wrote:
> 2010/2/6 Jakub Narebski <jnareb@gmail.com>:
>> On Thu, 4 Jan 2010, Giuseppe Bilotta wrote:

[...]
>>>  # return all refs matching refs/notes/<globspecs> where the globspecs
>>>  # are taken from the notes feature content.
>>>  sub get_note_refs {
>>> +     local $/ = "";
>>> +
>>
>> Why it is needed here?  Why you want to use empty lines as terminator
>> (which means reading whole paragraphs), while treating two or more
>> consecutive empty lines as a single empty line (according to
>> perlvar(1))?
>>
>> If you want to slurp whole file, this should be
>>
>>        local $/;
>>
>> or more explicit
>>
>>        local $/ = undef;
> 
> Ah, sorry, for some reason I thought "" was the default.

If you wanted to use default value, why set it at all?

-- 
Jakub Narebski
Poland