From: Larry D'Anna <larry@elder-gods.org>
Date: Fri, 05 Feb 2010 19:50:04 GMT
Subject: Re: [PATCH] fix an error message in git-push so it goes to stderr
Message-ID: <20100205195004.GA21772@cthulhu>
In-Reply-To: <20100205194824.GD24474@coredump.intra.peff.net>

* Jeff King (jrk@wrek.org) [100205 14:48]:
> On Fri, Feb 05, 2010 at 02:39:50PM -0500, Larry D'Anna wrote:
> 
> > Also it seems to me that git push --dry-run --porcelain should exit successfully
> > even if it knows some refs will be rejected.  The calling script can see just
> > fine for itself that they will be rejected, and it probably still wants to know
> > whether or not the dry-run succeeded, which has nothing to do with whether or
> > not the same push would succeed as a not-dry-run.
> 
> I think that is OK, but only if "git push --dry-run" still exits with an
> error case, since people may be using it for "will this push work?" and
> not simply "did an error occur?".

Yup.  That's exactly what the patch I just posted does.

      --larry