From: Shawn O. Pearce Date: Thu, 04 Feb 2010 04:00:46 GMT Subject: Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes Message-ID: <20100204040046.GR14799@spearce.org> In-Reply-To: <1265255308-20514-3-git-send-email-nico@fluxnic.net> Nicolas Pitre wrote: > The value passed to --max-pack-size used to count in MiB which was > inconsistent with the corresponding configuration variable as well as > other command arguments which are defined to count in bytes with an > optional unit suffix. This brings --max-pack-size in line with the > rest of Git. ... > Documentation/RelNotes-1.7.0.txt | 8 +++++++- > Documentation/config.txt | 11 +++++++---- > Documentation/git-pack-objects.txt | 5 +++-- > Documentation/git-repack.txt | 8 +++++--- > builtin-pack-objects.c | 11 ++++++----- > t/t5300-pack-object.sh | 14 ++++++++------ > 6 files changed, 36 insertions(+), 21 deletions(-) Shouldn't we also change fast-import.c ? -- Shawn.