From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 24 Jan 2010 19:20:08 GMT
Subject: Re: [PATCH] Windows: avoid static dependency on advapi32.dll
Message-ID: <201001242020.08534.j6t@kdbg.org>
In-Reply-To: <1264359231-4672-1-git-send-email-michael.lukashov@gmail.com>

On Sonntag, 24. Januar 2010, Michael Lukashov wrote:
> This DLL is used to get default user name. By looking
> up the only function that we need at runtime, we can
> avoid the startup costs of this DLL.

Sorry, no. This doesn't work. Even though git.exe does no longer depend on 
advapi32.dll directly, it does so indirectly (via ws_32.dll). This patch is 
not an improvement, therefore: NAK.

-- Hannes