From: Johannes Sixt Date: Fri, 22 Jan 2010 18:34:02 GMT Subject: Re: [PATCH] git-mv: Fix error with multiple sources. Message-ID: <201001221934.03346.j6t@kdbg.org> In-Reply-To: <7vr5pi8x6z.fsf@alter.siamese.dyndns.org> On Freitag, 22. Januar 2010, Junio C Hamano wrote: > Why does '/' matter in builtin-mv.c that needed b8f2626, but we can > compare with '/' [in make_relative_path()]? We should be using is_dir_sep() in make_relative_path() as well (see the fixup that I posted in response to your patch). The thing is that the incorrect result does not matter from a correctness-POV for the only caller of this routine. -- Hannes