From: Jeff King <peff@peff.net>
Date: Sun, 17 Jan 2010 16:18:30 GMT
Subject: Re: [PATCH v2 3/3] commit: show interesting ident information in summary
Message-ID: <20100117161830.GA7153@sigill.intra.peff.net>
In-Reply-To: <7vhbql85ti.fsf@alter.siamese.dyndns.org>

On Sun, Jan 17, 2010 at 12:59:53AM -0800, Junio C Hamano wrote:

> > @@ -1085,7 +1118,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)
> >  		struct pretty_print_context ctx = {0};
> >  		struct strbuf buf = STRBUF_INIT;
> >  		ctx.date_mode = DATE_NORMAL;
> > -		format_commit_message(commit, format + 7, &buf, &ctx);
> > +		format_commit_message(commit, format.buf + 7, &buf, &ctx);
> >  		printf("%s\n", buf.buf);
> 
> But sometimes log_tree_commit() doesn't show the header.  Most notably for
> merges.  What string are we using for format_commit_message()?  Oops.

Ugh. Thank you and good catch.

-Peff