From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Sat, 16 Jan 2010 15:56:12 GMT
Subject: Re: [PATCH v3] Add push --set-upstream
Message-ID: <20100116155612.GA8383@Knoppix>
In-Reply-To: <20100116233043.26a5636d.rctay89@gmail.com>

On Sat, Jan 16, 2010 at 11:30:43PM +0800, Tay Ray Chuan wrote:
> Hi,
> 
> On Sat, 16 Jan 2010 15:46:57 +0200
> Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:
> 
> > > Regarding the checking of ref->status here:
> > > 
> > > Is it possible to delegate this to push_had_errors(remote_refs)
> > > instead? We skip setting up upstream tracking when there are errors
> > > from pushing, so we don't have to check ref->status anymore.
> > 
> > No. As documetnation says, the update or no update is done on per-branch
> > basis.
> > 
> > <snip patch>
> 
> I see. If that's the case, could you also allow setting up upstream
> tracking when ref->status is 'none' and not consider it errorneous?
> 
> After all, push_had_errors() does not consider 'none' errorneous.

Hmm... In what conditions ref->status is 'none' after push operation
has completed?

-Ilari