From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 16 Jan 2010 10:38:36 GMT
Subject: Re: [PATCH v2 13/14] daemon: use select() instead of poll()
Message-ID: <201001161138.36535.j6t@kdbg.org>
In-Reply-To: <40aa078e1001160126q34bc066as3adb9b61eac690d@mail.gmail.com>

On Samstag, 16. Januar 2010, Erik Faye-Lund wrote:
> On Sat, Jan 16, 2010 at 9:06 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> > On Samstag, 16. Januar 2010, Erik Faye-Lund wrote:
> >> +static inline void mingw_fd_set(int fd, fd_set *set)
> >> +{
> >> +     FD_SET(_get_osfhandle(fd), set);
> >> +}
> >>  #undef FD_SET
> >> +#define FD_SET(a,b) mingw_fd_set(a,b)
> >> +
> >>  #undef FD_ISSET
> >>  #define FD_ISSET(fd, set) __WSAFDIsSet(_get_osfhandle(fd), (fd_set
> >> *)(set))
> >
> > Ah, yes, how obvious ;) You are going to do the same with FD_ISSET as
> > well, aren't you?
>
> Do I really need to? There's already a single function for that, with
> no "ugly hidden internals" there; __WSAFDIsSet() is documented in
> MSDN. I mean, Sure... I could... I just don't see the point.

__WSAFDIsSet is "ugly hidden internals" and we should not rely on it when we 
can use the official FD_ISSET for our own FD_ISSET.

-- Hannes