From: Richard Weinberger <richard@nod.at>
Date: Fri, 15 Jan 2010 11:02:38 GMT
Subject: Re: [PATCH 2/2] Fix variable initialization in insert_packed_refs().
Message-ID: <201001151202.38762.richard@nod.at>
In-Reply-To: <4B501A9D.6060703@viscovery.net>

Am Freitag 15 Januar 2010 08:34:53 schrieb Johannes Sixt:
> If you look around in the code, you'll find more *cough* initializations
> *cough* like this. They are written this way for a reason: they avoid
> unwarranted compiler warnings "'foo' may be used uninitialized". Are you
> saying that this warning is not triggered anymore after your change?
> 

I don't get a warning after my change. 
But I'm using on this system a quite old gcc (4.3.1).
I'll recompile git with a more recent gcc and see what happens.

Just for clarification:
"int cmp = cmp;"
*suppresses* only the warning but "cmp" is still uninitialized?
(I did'nt know this trick before.)

//richard