From: Jonathan Nieder Date: Wed, 06 Jan 2010 06:37:59 GMT Subject: [PATCH v2] Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGS Message-ID: <20100106063759.GA882@progeny.tock> In-Reply-To: <20091128113323.GC10059@progeny.tock> The %.o: %.S pattern rule should depend on GIT-CFLAGS to avoid trouble when ALL_CFLAGS changes. The pattern only applies to one file (ppc/sha1ppc.S) and that file does not use any #ifdefs, so leaving the dependency out is probably harmless. Nevertheless, it is safer to include the dependency in case future code's behavior does depend on the build flags. Signed-off-by: Jonathan Nieder --- Hopefully the justification is a little clearer this time. This is not a high-priority change. The problem it addresses is only an aesthetic one as far as I can tell. Still, I would be happy to see it fixed; thanks for the reminder. Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index c11719c..015bfab 100644 --- a/Makefile +++ b/Makefile @@ -1635,7 +1635,7 @@ git.o git.spec \ $(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $< %.s: %.c GIT-CFLAGS $(QUIET_CC)$(CC) -S $(ALL_CFLAGS) $< -%.o: %.S +%.o: %.S GIT-CFLAGS $(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $< exec_cmd.o: exec_cmd.c GIT-CFLAGS -- 1.6.6.rc2