From: Jeff King <peff@peff.net>
Date: Sun, 03 Jan 2010 07:24:08 GMT
Subject: Re: [PATCH 7/6] t0021: use $SHELL_PATH for the filter script
Message-ID: <20100103072408.GA23031@sigill.intra.peff.net>
In-Reply-To: <4B3E73AE.6050003@kdbg.org>

On Fri, Jan 01, 2010 at 11:14:06PM +0100, Johannes Sixt wrote:

> On Windows, we need the shbang line to correctly invoke shell scripts via
> a POSIX shell, except when the script is invoked via 'sh -c' because
> sh (a bash) does "the right thing". Since nowadays the clean and smudge
> filters are not always invoked via 'sh -c' anymore, we have to mark the
> the one in t0021-conversion with #!$SHELL_PATH.

Hrm. This does mean we might be breaking users who have helper scripts
in a similar state to those in the test suite (of course, so does your
pager hack, or anything which might optimize out a shell call).  But
perhaps given that scripts without a shebang generally don't work on
Windows, they are not too common and we don't need to worry about it.

-Peff