From: Jeff King <peff@peff.net>
Date: Fri, 01 Jan 2010 04:50:18 GMT
Subject: Re: [PATCH 3/6] run-command: optimize out useless shell calls
Message-ID: <20100101045017.GA20769@coredump.intra.peff.net>
In-Reply-To: <200912312316.47925.j6t@kdbg.org>

On Thu, Dec 31, 2009 at 11:16:47PM +0100, Johannes Sixt wrote:

> > > It does assume that we are able to detect execvp failure due to
> > > ENOENT which is currently proposed elsewhere by Ilari Liusvaara (and
> > > which is already possible on Windows).
> >
> > We could also simply do the path lookup ourselves, decide whether to use
> > the shell, and then exec.
> 
> I tried to convince Ilari that this is the way to go, but...

How should we proceed, then? The "DWIM with spaces" magic seems like
something that can come later, so I am tempted to recommend taking my
series now, fixing up msysgit as mentioned earlier (or just dropping the
pager.c portion of my 2/6), and then implementing DWIM once Ilari's
topic matures.

We might want to hold my 5/6 and 6/6 back from master until the DWIM
(which would make both totally safe, I think).

-Peff