From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 31 Dec 2009 22:16:47 GMT
Subject: Re: [PATCH 3/6] run-command: optimize out useless shell calls
Message-ID: <200912312316.47925.j6t@kdbg.org>
In-Reply-To: <20091231214134.GA31399@coredump.intra.peff.net>

On Donnerstag, 31. Dezember 2009, Jeff King wrote:
> But of course if we use your trick internally in run-command, then your
> pager-specific change can just go away.

This is what I had in mind.

> > It does assume that we are able to detect execvp failure due to
> > ENOENT which is currently proposed elsewhere by Ilari Liusvaara (and
> > which is already possible on Windows).
>
> We could also simply do the path lookup ourselves, decide whether to use
> the shell, and then exec.

I tried to convince Ilari that this is the way to go, but...

-- Hannes