From: Jeff King <peff@peff.net>
Date: Wed, 30 Dec 2009 11:05:57 GMT
Subject: Re: Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy
Message-ID: <20091230110557.GG22959@coredump.intra.peff.net>
In-Reply-To: <7vmy1051ik.fsf@alter.siamese.dyndns.org>

On Wed, Dec 30, 2009 at 12:06:43AM -0800, Junio C Hamano wrote:

> Nanako Shiraishi <nanako3@lavabit.com> writes:
> 
> > Junio, could you tell us what happened to this thread?
> >
> > I think this is probably related to the "textconv" change.
> 
> Yeah, you guessed right. I think the unified way to launch user specified
> programs would come first and then spawning proxy the same way as others
> would become trivial.

As a "7/6" on top of my other series, this should just be:

diff --git a/connect.c b/connect.c
index db965c9..838146c 100644
--- a/connect.c
+++ b/connect.c
@@ -432,6 +432,7 @@ static void git_proxy_connect(int fd[2], char *host)
 	argv[2] = port;
 	argv[3] = NULL;
 	memset(&proxy, 0, sizeof(proxy));
+	proxy.use_shell = 1;
 	proxy.argv = argv;
 	proxy.in = -1;
 	proxy.out = -1;

But I will leave it to somebody who actually uses the proxy feature to
test and submit a patch.

-Peff