From: Shawn O. Pearce <spearce@spearce.org>
Date: Mon, 28 Dec 2009 15:59:31 GMT
Subject: Re: [PATCH 2/2] Smart-http: check if repository is OK to export before serving it
Message-ID: <20091228155931.GC2252@spearce.org>
In-Reply-To: <905315640912272007i8b4904dv2b93879789b453fb@mail.gmail.com>

Tarmigan <tarmigan+git@gmail.com> wrote:
> On Sun, Dec 27, 2009 at 4:10 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Tarmigan Casebolt <tarmigan+git@gmail.com> wrote:
> >> Similar to how git-daemon checks whether a repository is OK to be
> >> exported, smart-http should also check. ?This check can be satisfied
> >> in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
> >> may be set to export all repositories, or the individual repository
> >> may have the file git-daemon-export-ok.
...
> I've been thinking that the not_found() to a forbidden() instead.

Oh.  Interesting question.

Because you can't resolve the access error by authenticating to
the server, we may actually want to just return not_found() here
with a message in the log of "Repository not exported: '%s'".

That would mirror the behavior of git-daemon.

-- 
Shawn.