From: Bernhard R. Link Date: Thu, 17 Dec 2009 09:35:47 GMT Subject: Re: [PATCH] Let format-patch and rebase ignore trivial merges. Message-ID: <20091217093547.GA25451@pcpool00.mathematik.uni-freiburg.de> In-Reply-To: <4B29106C.1040501@viscovery.net> * Johannes Sixt [091216 17:53]: > Bernhard R. Link schrieb: > > --prune-tree makes rev-list without paths equivalent to > > "git rev-list $options -- ." (or .. or ../.. and so on, > > if you are in some subdirectory). > > This is the new default for format-patch and rebase > > Why do you need a new option when you can just add "-- ." to the rev-list > invocation? I want the default for format-patch changed. For this I think it is easiest to add a new rev_info flag, as otherwise format-patch would need to duplicate parsing the rev_list options and either duplicate applying revs->prune_data or changing the argv for setup_revisions with some special casing of bare repository and non-bare repository cases. And if there is that rev_info flag I think it is most logical to make it accessible from the outside. That also allows to revert to the old format-patch behaviour, in case someone uses format-patch not to get some appliable patches but some differently formated log or for something else I cannot imagine. And when there is that option, I think it is more robust to use that in merge -m and merge -i, as "-- ." only does the right thing by chance because both only work with a non-bare repository and have cd_to_toplevel. Hochachtungsvoll, Bernhard R. Link -- Please do not CC me if git@vger.kernel.org also gets a copy.