From: Paul Mackerras Date: Mon, 14 Dec 2009 03:28:16 GMT Subject: Re: [PATCH 2/2] Add gitk-git Hungarian translation Message-ID: <20091214032816.GB24152@drongo> In-Reply-To: <7vskbejmrw.fsf@alter.siamese.dyndns.org> On Sun, Dec 13, 2009 at 06:46:11PM -0800, Junio C Hamano wrote: > Paul Mackerras writes: > > > In any case, your patch has problems: I applied it and then ran > > make to update the message catalogs, and I got these errors: > > > > Generating catalog po/hu.msg > > msgfmt --statistics --tcl po/hu.po -l hu -d po/ > > po/hu.po:41: end-of-line within string > > po/hu.po:41:4: syntax error > > po/hu.po:42: end-of-line within string > > po/hu.po:666: end-of-line within string > > po/hu.po:666:10: syntax error > > po/hu.po:667: end-of-line within string > > msgfmt: found 6 fatal errors > > make: *** [po/hu.msg] Error 1 > > > > so I reverted it. > > Syntactically there seem to be only two line-wrapping caused by MUA on the > originating side that caused this. Munging the problematic lines seems to > fix the above. It didn't look to me as though it was just MUA line-wrapping, since there was a '+' at the start of the line following the one that didn't have a closing quote. Also, git am didn't complain about it, which it would have done if it had been MUA line-wrapping. > Now, I don't read _any_ Hungarian, so it could very well be that my fix-up > is wrong and there shouldn't be any SP between two words in 'fájlon belül' > and 'még nincsenek'; if we hear from some Hungarian capable readers that the > fix-up below makes sense, perhaps squashing it in would be the easiest way > to move forward? I also don't read any Hungarian, which is why I didn't want to try to fix up problems that were more than just MUA line-wrapping. As you say, if a Hungarian speaker can verify that your fix is correct, we could fix up the original patch. A clean re-post with a suitable subject would be nicer, though. Paul.