From: Shawn O. Pearce Date: Mon, 07 Dec 2009 15:37:36 GMT Subject: Re: What's cooking in git.git (Dec 2009, #02; Sat, 05) Message-ID: <20091207153736.GC17173@spearce.org> In-Reply-To: Martin Storsj? wrote: > On Sun, 6 Dec 2009, Junio C Hamano wrote: > > > > * tr/http-updates (2009-12-01) 3 commits > > - Allow curl to rewind the RPC read buffer > > - Add an option for using any HTTP authentication scheme, not only basic > > - http: maintain curl sessions > > > > There was a discussion on a better structure not to require rewinding in > > the first place? I didn't follow it closely... > > I think the conclusion is: Rewinding support isn't strictly necessary, > there's a number of mechanisms in both git and curl that should make sure > that those cases shouldn't surface. A few of them in curl have an > unfortunate conincidence of bugs up until the latest version, though, > leaving much fewer mechanisms in place to avoid this. > > Since that patch is quite non-intrusive I think it's a good safeguard, > though. What do you think, Tay, keep it or leave it? I think the conclusion of the thread was that what you have queued in tr/http-updates is OK as-is. The patch to grow the postbuffer to store the entire request wasn't a good idea and got dropped. -- Shawn.