From: Jeff King <peff@peff.net>
Date: Sat, 05 Dec 2009 16:14:05 GMT
Subject: Re: [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE.
Message-ID: <20091205161405.GA9272@sigill.intra.peff.net>
In-Reply-To: <1259968322-66072-1-git-send-email-jh@jameshoward.us>

On Fri, Dec 04, 2009 at 06:12:02PM -0500, James P. Howard, II wrote:

> --- a/utf8.c
> +++ b/utf8.c
> @@ -449,7 +449,7 @@ char *reencode_string(const char *in, const char *out_encoding, const char *in_e
>  	cp = (iconv_ibp)in;
>  
>  	while (1) {
> -		size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz);
> +		size_t cnt = iconv(conv, (const char **)&cp, &insz, &outpos, &outsz);
>  
>  		if (cnt == -1) {
>  			size_t sofar;

Aren't you now introducing a warning for all of the other platforms
which take a "char **"? Should you instead just be building with
OLD_ICONV=Yes on your platform? See commit fd547a9 for details.

-Peff