From: Shawn O. Pearce Date: Fri, 04 Dec 2009 15:57:51 GMT Subject: Re: [PATCH] git-gui: suppress the X error on exit Message-ID: <20091204155751.GB1483@spearce.org> In-Reply-To: <20091204102844.3c720b21@starbug.prg01.itonis.net> Jindrich Makovicka wrote: > Due to a bug in Tk, git-gui almost always (unless git-gui is closed > right after starting) produces an X window error message on exit, > something like Thanks. I've wrapped it up into the following commit. Can I get a Signed-off-by line from you? --8<-- [PATCH] git-gui: suppress RenderBadPicture X error caused by Tk bug Due to a bug in Tk, git-gui almost always (unless git-gui is closed right after starting) produces an X window error message on exit, something like: X Error of failed request: RenderBadPicture (invalid Picture parameter) Major opcode of failed request: 150 (RENDER) Minor opcode of failed request: 7 (RenderFreePicture) Picture id in failed request: 0x3a000dc Serial number of failed request: 1965 Current serial number in output stream: 1980 Respective Tk bug report is here: http://sourceforge.net/tracker/?func=detail&atid=112997&aid=1821174&group_id=12997 This bug is triggered only when the send command is blocked via rename send {} . The following patch re-enables send just before quiting git-gui to suppress the error. Signed-off-by: Shawn O. Pearce --- git-gui.sh | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/git-gui.sh b/git-gui.sh index 037a1f2..718277a 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -2052,6 +2052,11 @@ proc do_quit {{rc {1}}} { } set ret_code $rc + + # Briefly enable send again, working around Tk bug + # http://sourceforge.net/tracker/?func=detail&atid=112997&aid=1821174&group_id=12997 + tk appname [appname] + destroy . } -- 1.6.6.rc0.324.gb5bf2 -- Shawn.