From: Shawn O. Pearce <spearce@spearce.org>
Date: Wed, 02 Dec 2009 17:12:08 GMT
Subject: Re: [RFC PATCH 4/8] Support remote helpers implementing smart transports
Message-ID: <20091202171208.GD31648@spearce.org>
In-Reply-To: <20091202055543.GC31244@Knoppix>

Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:
> On Tue, Dec 01, 2009 at 11:22:33AM -0800, Shawn O. Pearce wrote:
>  
> > Why 'OK'?  Currently remote-helpers return an empty blank line
> > to any successful command, not 'OK'.
> 
> Changed to "" (i.e. blank line) for next round.

Arrrgh.  Just to correct myself... the 'option' command uses 'ok',
'error', 'unsupported' as its response messages.  Which means
'option' breaks the blank-line-is-ok convention I tried to hold
you to above.

I consider this a mistake on my part.  'option' should respond with
a blank line on success just like 'fetch' or 'push' does.

-- 
Shawn.