From: Ilari Liusvaara Date: Wed, 02 Dec 2009 16:04:47 GMT Subject: Re: [RFC PATCH 0/8] Git remote helpers to implement smart transports. Message-ID: <20091202160446.GA32667@Knoppix> In-Reply-To: <7vy6llnar5.fsf@alter.siamese.dyndns.org> On Tue, Dec 01, 2009 at 10:35:58PM -0800, Junio C Hamano wrote: > Ilari Liusvaara writes: > > I didn't mean the line count by "large". I was referring to the size of > change at the conceptual level. As Daniel already explained, it has been > one of the design assumption so far that there are built-in mappings from > some common :// to backend "helpers". No implicit mappings from :// to helpers existed before this series (except for forcing in URL, which are different). Thus, any mapping had to be explicit and built-in. And if mappings http -> curl, https -> curl, ftp -> curl are to remain explicit in main git binary, I would put them into table and build stub remote-curl if NO_CURL is defined instead of special casing the error in main git binary (but I consider that worse than just removing the association from main git binary). >From file system listing on this computer (note the I-node numbers, this is on newer version of change than the one sent): 2068945 -rwxr-xr-x 4 Ilari users 1547231 2009-12-02 15:12 /home/Ilari/.local/git-testing/libexec/git-core/git-remote-ftp 2068945 -rwxr-xr-x 4 Ilari users 1547231 2009-12-02 15:12 /home/Ilari/.local/git-testing/libexec/git-core/git-remote-ftps 2068945 -rwxr-xr-x 4 Ilari users 1547231 2009-12-02 15:12 /home/Ilari/.local/git-testing/libexec/git-core/git-remote-http 2068945 -rwxr-xr-x 4 Ilari users 1547231 2009-12-02 15:12 /home/Ilari/.local/git-testing/libexec/git-core/git-remote-https So instead of mapping explicitly, those are effectively mapped by filesystem (that's after the fixes for next round that make helpers hardlinked instead of copied). -Ilari