From: Christian Couder <chriscool@tuxfamily.org>
Date: Wed, 18 Nov 2009 06:48:41 GMT
Subject: Re: [PATCH 1/2] replace: use a GIT_NO_REPLACE_OBJECTS env variable
Message-ID: <200911180748.42061.chriscool@tuxfamily.org>
In-Reply-To: <4B0253DA.1090003@viscovery.net>

On mardi 17 novembre 2009, Johannes Sixt wrote:
> Christian Couder schrieb:
> > diff --git a/git.c b/git.c
> > index bd2c5fe..7f7d73d 100644
> > --- a/git.c
> > +++ b/git.c
> > @@ -89,6 +89,9 @@ static int handle_options(const char ***argv, int
> > *argc, int *envchanged) *envchanged = 1;
> >  		} else if (!strcmp(cmd, "--no-replace-objects")) {
> >  			read_replace_refs = 0;
> > +			setenv(NO_REPLACE_OBJECTS_ENVIRONMENT, "", 1);
>
> It is safer to set to a non-empty string, e.g., "1".

Ok, I will use a non empty string.

> I think this variable should be added to the list in connect.c around
> line 630 so that it does not propagate to the remote end.

Ok, I have done that in the version I will send.

Thanks,
Christian.