From: Jeff King <peff@peff.net>
Date: Wed, 04 Nov 2009 07:37:31 GMT
Subject: Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat
Message-ID: <20091104073731.GA15408@coredump.intra.peff.net>
In-Reply-To: <4AF12EC5.4030407@gmail.com>

On Tue, Nov 03, 2009 at 11:35:33PM -0800, Stephen Boyd wrote:

> >@@ -940,6 +941,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
> > 		{ OPTION_CALLBACK, 0, "thread", &thread, "style",
> > 			    "enable message threading, styles: shallow, deep",
> > 			    PARSE_OPT_OPTARG, thread_callback },
> >+		OPT_BOOLEAN('p', NULL, &use_patch_format,
> >+			"show patch format instead of default (patch + stat)"),
> > 		OPT_END()
> > 	};
> 
> I don't imagine we want this option in the messaging group though.
> Can you move it up?

Thanks, good catch. I just tacked it onto the end, forgetting that we
were using grouping. Junio, can you tweak it, or do you want a resend?

-Peff