From: Johan Herland Date: Sat, 31 Oct 2009 12:04:05 GMT Subject: Re: [PATCH 10/19] Allow helpers to request marks for fast-import Message-ID: <200910311304.05408.johan@herland.net> In-Reply-To: On Friday 30 October 2009, Sverre Rabbelier wrote: > Heya, > > On Fri, Oct 30, 2009 at 01:21, Johan Herland wrote: > > Please drop this patch from the series. The functionality is not > > needed, since we'll use the fast-import "option" command from the > > sr/gfi-options series instead. > > In that case I will rebase the series on top of sr/gfi-options then as > soon as I reroll that one. Good. > Also, do you need to change anything else in git-remote-cvs to do that? Yes, the sr/gfi-options series does cause some changes, both in git-remote- cvs, and in the support libraries (adding a couple of methods to the GitFastImport class in git.py). This conglomeration of patch series is becoming fairly complicated, and it's becoming hard to stay in sync. I suggest that you drop the CVS-specific parts from this series, and work on stabilizing the common infrastructure. Once that has settled, you can send a git-remote-hg series, and I can send a rebased and updated git-remote-cvs series. Feel free to reorganize the patches so that the git_remote_helpers infrastructure is created in the correct location (instead of reorganizing git_remote_cvs). ...Johan -- Johan Herland, www.herland.net