From: Jonathan Nieder Date: Sat, 31 Oct 2009 04:53:58 GMT Subject: Re: [PATCH v3] Teach git var about GIT_EDITOR Message-ID: <20091031045358.GA9565@progeny.tock> In-Reply-To: <20091031040436.GB6022@progeny.tock> A typo fix --- sorry for the noise. Jonathan Nieder wrote: > --- a/var.c > +++ b/var.c > @@ -8,6 +8,16 @@ > > static const char var_usage[] = "git var [-l | ]"; > > +static const char *editor(int flag) > +{ > + const char *pgm = git_editor(); > + > + if (!pgm && flag & IDENT_ERROR_ON_NO_NAME) > + die("terminal is dumb, but VISUAL and EDITOR unset"); Agh... s/VISUAL and //. All right, time to sleep. Apologies for all the mistakes, and thanks for the help catching them. Kind regards, Jonathan