From: Shawn O. Pearce Date: Fri, 30 Oct 2009 23:59:36 GMT Subject: Re: [RFC PATCH v4 14/26] Add stateless RPC options to upload-pack, receive-pack Message-ID: <20091030235936.GH10505@spearce.org> In-Reply-To: <7vtyxi53sh.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > I think that is probably too much complexity for too little gain. I think > detecting stale request and having requestor retry would be sufficient, > and validating the want lines as we already do would give the same level > of assurance as "check against the hash of first phase response" I > outlined above, and would be much simpler thus more robust. Ack. I think what we want here is to just add an "ERR invalid want" message just before disconnecting when the client gives us a SHA-1 which we don't point to directly. Client implementations can choose how to handle this error. They could retry from the beginning, or they could abort. -- Shawn.