From: Johannes Sixt <j.sixt@viscovery.net>
Date: Thu, 29 Oct 2009 20:57:36 GMT
Subject: Re: [PATCH/RFC 2/2] Provide a build time default-editor setting
Message-ID: <200910292157.37474.j.sixt@viscovery.net>
In-Reply-To: <7viqdy6ii1.fsf@alter.siamese.dyndns.org>

On Donnerstag, 29. Oktober 2009, Junio C Hamano wrote:
> Johannes Sixt <j.sixt@viscovery.net> writes:
> > Something like below? Possible usage in shell scripts:
> >
> > 	editor=$(git var GIT_EDITOR)
> > 	"$editor" "$filename"
>
> I think we support GIT_EDITOR that is command path plus its initial
> command line arguments, so you do not want dq around $editor, right?

Yeah, whatever, I didn't take the time to think it through. But this may be an 
opportunity to give some life back to the zombie that git-var currently is, 
that is, to make it the plumbing that does value discovery for variables like 
GIT_AUTHOR_INDENT, GIT_COMMITTER_IDENT, GIT_EDITOR, and perhaps also 
GIT_PAGER.

-- Hannes