From: Jonathan Nieder Date: Thu, 29 Oct 2009 07:32:24 GMT Subject: [PATCH 0/2] Re: packaging vs default pager Message-ID: <20091029073224.GA15403@progeny.tock> In-Reply-To: <7vskd3o11t.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Ben Walton writes: >> Would it be completely out of line to provide a knob so that the >> fallback $pager could be set to something more specific/appropriate >> during the build? > > I think that is a sensible thing to do. Something like this? > > Makefile | 6 ++++++ > pager.c | 6 +++++- > 2 files changed, 11 insertions(+), 1 deletions(-) That looks good to me, but it’s missing a corresponding change to git-svn. I think something like this could be useful for Debian to avoid patching to comply with the distro policy of falling back to generic "pager" and "editor" symlinks. How about the following two patches? Jonathan Nieder (1): Provide a build time default-editor setting Junio C Hamano (1): Provide a build time default-pager setting Makefile | 18 ++++++++++++++++++ editor.c | 2 +- git-add--interactive.perl | 3 ++- git-sh-setup.sh | 6 ++++-- git-svn.perl | 8 +++++--- pager.c | 2 +- t/Makefile | 2 ++ t/t7005-editor.sh | 29 ++++++++++++++++++++++------- 8 files changed, 55 insertions(+), 15 deletions(-)