From: Jeff King <peff@peff.net>
Date: Tue, 27 Oct 2009 18:31:05 GMT
Subject: Re: [PATCH] Fix memory leak in transport-helper
Message-ID: <20091027183105.GA9504@sigill.intra.peff.net>
In-Reply-To: <alpine.LNX.2.00.0910271329510.14365@iabervon.org>

On Tue, Oct 27, 2009 at 01:37:19PM -0400, Daniel Barkalow wrote:

> > Why did you not leech the transport->data = NULL; part from Peff/Sverre's 
> > patch?
> 
> Because this code is only called just before transport itself is freed by 
> the caller, and, in general, a transport with these methods is invalid 
> without a valid transport->data. I expect that's also why Peff called it a 
> hack not appropriate for actual application.

More or less. I called it a hack because I didn't even look far enough
to know whether or not that was the case. I was just trying to get it to
stop segfaulting so Sverre could continue his work.

-Peff