From: Bernhard Reutner-Fischer Date: Sat, 24 Oct 2009 10:05:02 GMT Subject: Re: [PATCH] tar: on extract, -o is --no-same-owner Message-ID: <20091024100502.GG4615@mx.loc> In-Reply-To: On Sat, Oct 24, 2009 at 11:49:10AM +0200, Andreas Schwab wrote: >Bernhard Reutner-Fischer writes: > >> On Fri, Oct 23, 2009 at 02:26:53PM -0700, Junio C Hamano wrote: >>>Bernhard Reutner-Fischer writes: >>> >>>> On Fri, Oct 23, 2009 at 10:25:24PM +0200, Bernhard Reutner-Fischer wrote: >>>>>On Fri, Oct 23, 2009 at 10:15:43PM +0200, Bernhard Reutner-Fischer wrote: >>>>>>GNU tar-1.22 handles 'o' as no-same-owner only on extract, >>>>>>on create, 'o' would be --old-archive. >>>>> >>>>>FYI this was prompted by: >>>>> >>>>>Signed-off-by: Bernhard Reutner-Fischer >>>>> >>>>>diff -rdup git-1.6.5.oorig/templates/Makefile git-1.6.5/templates/Makefile >>>>>--- git-1.6.5.oorig/templates/Makefile 2009-10-11 03:42:04.000000000 +0200 >>>>>+++ git-1.6.5/templates/Makefile 2009-10-23 21:43:06.000000000 +0200 >>>>>@@ -50,4 +50,4 @@ clean: >>>>> install: all >>>>> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(template_instdir_SQ)' >>>>> (cd blt && $(TAR) cf - .) | \ >>>>>- (cd '$(DESTDIR_SQ)$(template_instdir_SQ)' && umask 022 && $(TAR) xfo -) >>>>>+ (cd '$(DESTDIR_SQ)$(template_instdir_SQ)' && umask 022 && $(TAR) x --no-numeric-owner -f -) >>>> >>>> argh, sorry! --no-same-owner of course. >>> >>>Either way, your change would break non-GNU tar implementations that are >>>properly POSIX.1, isn't it? >> >> I suppose xf - -o would work? > >Isn't that the same as 'xfo -'? Not really (if you do not permute the arguments which we don't in busybox, for size reasons). f specifies the file so "fo" acts on file "o". "xof -" would work for me as well as "xf - -o", it's just that "xfo -" does not work.